[flashrom] [PATCH 1/3] 128 bytes write granularity support

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sun Oct 18 20:58:34 CEST 2015


Hi Paul,

On 18.10.2015 19:37, Paul Kocialkowski wrote:
> I noticed that you have reworded the commit message: I usually do not > use conjugated verbs in commit headline. Does this conflict with >
flashrom's guidelines?

No formal guidelines, but "128 bytes write granularity support" is
missing a crucial piece of information: Was this a bugfix, a new feature
or something you removed?
The reworded commit message has that info.

> It looks a bit strange to me to have my commit worded in a way that > really does not match what I naturally do!

Regards,
Carl-Daniel





More information about the flashrom mailing list