[flashrom] [PATCH] Reset before reading Chip ID
audiohacked at gmail.com
Sun Sep 19 17:06:08 CEST 2010
On 9/15/10 4:23 AM, Carl-Daniel Hailfinger wrote:
> On 04.02.2010 07:13, Sean Nelson wrote:
>> I'd like Uwe, Stepan, or Carl-Daniel to test this and send an ack/nack.
>> On 1/31/10 8:07 AM, Anders Juel Jensen wrote:
>>> On Sunday 31 January 2010 06:33:12 Sean Nelson wrote:
>>>> Add a reset to probe_jedec before we read the Chip's IDs.
>>>> Signed-off-by: Sean Nelson<audiohacked at gmail.com>
>>> Acked-by: Anders Juel Jensen<andersjjensen at gmail.com>
> Sorry for the long delay. We absolutely want this patch, and I'm happy
> with it except for two minor issues:
> - Previous probes might have had too short delays for entering ID mode,
> so the chip may still be in the process of entering the ID mode. Due to
> that, an additional delay before the reset makes sense.
> - We needed FEATURE_RESET_MASK to deal cleanly with those feature bits.
> Maciej Pijanka tested the patch and it fixes probing for him with some
> old Atmel chips.
> Signed-off-by: Sean Nelson<audiohacked at gmail.com>
> Signed-off-by: Carl-Daniel Hailfinger<c-d.hailfinger.devel.2006 at gmx.net>
> Acked-by: Anders Juel Jensen<andersjjensen at gmail.com>
Acked-by: Sean Nelson <audiohacked at gmail.com>
More information about the flashrom